Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean b* themes #1790

Merged
merged 10 commits into from
Jan 26, 2021
Merged

Clean b* themes #1790

merged 10 commits into from
Jan 26, 2021

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Jan 16, 2021

Description

Clean and lint b* themes

Motivation and Context

#1696

How Has This Been Tested?

Tested all themes before and after changes.
1 error was detected, resulting in an other PR: #1789

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@BarbUk BarbUk changed the title Update b* themes Clean b* themes Jan 16, 2021
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!
Thank you @BarbUk !!
I left a comment, that require you to change some things back to the way they were, but otherwise it looks really good 😄

themes/brainy/brainy.theme.bash Outdated Show resolved Hide resolved
@BarbUk BarbUk requested a review from NoahGorny January 16, 2021 22:42
@BarbUk
Copy link
Contributor Author

BarbUk commented Jan 22, 2021

@cornfeedhobo made a good argument in #1791 (comment), we should not change the code for COMPREPLY array when we know that the string used is safe.

The warning is now disabled only for the appropriate lines.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will let other folks chime in if they want, but well done @BarbUk !
Thank you for helping us make a big step into making this project a cleaner place 😄

@BarbUk
Copy link
Contributor Author

BarbUk commented Jan 23, 2021

Thank you for helping us make a big step into making this project a cleaner place

I use bash-it since ~2011, it's great to give a little time to the project :)

@NoahGorny NoahGorny merged commit 7b817f3 into Bash-it:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants