Vendor apm completion #1835
Merged
Vendor apm completion #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably should mention vendored |
|
@NoahGorny for when you have the time |
|
Should I add cite "about-completion"
about-completion "apm completion"at the top of |
Seems like a good idea 😄 |
|
@buhl you no longer need the |
buhl
force-pushed
the
vendor-apm-completion
branch
from
a2b1d0a
to
fd4f867
Compare
…ommit d44593c git-subtree-dir: vendor/github.com/vigo/apm-bash-completion git-subtree-split: d44593c3f0514e1fcc668e47f875f83ceb054b36
…n@master" git-vendor-name: apm-completion git-vendor-dir: vendor/github.com/vigo/apm-bash-completion git-vendor-repository: https://github.com/vigo/apm-bash-completion git-vendor-ref: master
buhl
force-pushed
the
vendor-apm-completion
branch
from
fd4f867
to
7fb7e27
Compare
|
@NoahGorny Should be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1818
Description
Removed code from
completion/available/apm.completion.bashAdded https://github.com/vigo/apm-bash-completion as a vendored lib
and sourced it from
apm.completion.bashMotivation and Context
#1818 and potentially #1819
How Has This Been Tested?
I have run the tests locally and enabled/disabled the completion locally as well.
Screenshots (if appropriate):
Types of changes
Vendored apm completion lib
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.