-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added completion for dart cli #1852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tbhaxor, I added some comments, you are welcome to take a look
nice job 😄
@NoahGorny I will fix this in this weekend I want to add nested completion for
How can I achieve this? Thanks in advance 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NoahGorny This is done
dccd0a1
to
ed97b9d
Compare
@NoahGorny Its done plz chk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@NoahGorny ping |
I dont understand what you mean, this is my output:
This is not what you want? |
@NoahGorny My bad, I wasn't clear enough See, we have completed for dart, and its arguments like I need to add the completions for |
@NoahGorny Also for such KB, it's hard to search through pull requests. Should we start GitHub discussions for such things? |
@NoahGorny Ping 😄 |
You can use the |
I will merge this as is- after I will release a stable version today |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.