Fixed defaults autocompletion. #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use grep WITHOUT case-sensitivity. Otherwise results such as com.apple.iChat and com.apple.imagent won't be handled correctly and neither one can be completed. Fixed another comparison that prevented "defaults read com.apple.iChat <complete>" from correctly returning the available defaults keys in that file.
|
Merging with sudo powers as this is a rebased version of #188 |
| @@ -56,7 +56,7 @@ _defaults() | |||
|
|
|||
| # Both a domain and command have been specified | |||
|
|
|||
| if [[ ${COMP_WORDS[1]} == [${cmds// /|}] ]]; then | |||
| if [[ ${COMP_WORDS[1]} =~ [${cmds// /|}] ]]; then | |||
There was a problem hiding this comment.
How did the =~ sneak into here?
We have at least 2 other uses of the == version in this file, and I thought we discussed previously that $cmds is not a regex? I'll have to look for that discussion.
There was a problem hiding this comment.
woah, I completely missed it!
That's totally my bad...
We should opt for the solution with _bash-it-array-contains-element instead.
I have also seen other problems with this completion...
I will try to create a PR for it
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dup of #188, rebased 😄