Lib/search: lint, cleanup, and small fixes #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
search
branch
9 times, most recently
from
a8004dd
to
99f4a91
Compare
gaelicWizard
force-pushed
the
search
branch
9 times, most recently
from
64b3f71
to
641e894
Compare
gaelicWizard
force-pushed
the
search
branch
11 times, most recently
from
ddf1c05
to
b9d2ee9
Compare
gaelicWizard
force-pushed
the
search
branch
4 times, most recently
from
cf73bb9
to
61373df
Compare
tsiflimagas
reviewed
Jan 4, 2022
tsiflimagas
reviewed
Jan 6, 2022
gaelicWizard
force-pushed
the
search
branch
7 times, most recently
from
a19e718
to
0395716
Compare
gaelicWizard
force-pushed
the
search
branch
2 times, most recently
from
9f4c7f2
to
55174c9
Compare
|
Rebased on current master and ready to go! |
NoahGorny
approved these changes
Jan 25, 2022
gaelicWizard
force-pushed
the
search
branch
2 times, most recently
from
0e494fe
to
24636b6
Compare
Couldn't even `shellcheck` until I did a first pass...too much noise! ♥
SC2076 SC2091 SC2004 SC2086 SC2207
1. `$text_black` isn't a parameter provided by _Bash It_. Typo? 2. `$bold_yellow` is meant for prompt strings and putputs `\[`; ditto `$bold_red`. 3. The color was never returned to normal after.
My apologies to future `git blame` hunters ♥
Improve `_bash-it-erase-term()`, `_bash-it-flash-term()`, `_bash-it-rewind()`, `_bash-it-search-result()`, and `_bash-it-search-component()`. Minor tweaks to `_bash-it-is-partial-match()`, and `_bash-it-search()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit notes as appropriate.
Description
This is a partial PR covering only the
lib/searchportion of #1917 in support of #1696.Motivation and Context
My
shellcheckbranch (#1917) got a bit large, so I'm splitting it up. This PR is inclusive of myhelpers(#1934) branch.How Has This Been Tested?
The full test suite and
shellcheckhave run on #1917 and this is part of my main branch.Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.