Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: use _save-and-reload-history() #1941

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 10, 2021

Description

Replaces

history -a
history -c
history -r

with a single call to _save-and-reload-history() in all themes. Alsö, remove executable bit.

Motivation and Context

This is inspired by #1595 and does not depend on #1940, so I made a separate PR.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

First pass to use _Bash It_'s automatic history management.
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
This should not change any behaviour, right?

@gaelicWizard
Copy link
Contributor Author

Nice work!
This should not change any behaviour, right?

In this PR, I specifically only replaced calls to all three lines with the function that calls all three lines. There should be absolutely no behavior changes.

@NoahGorny NoahGorny merged commit f9de8d1 into Bash-it:master Sep 16, 2021
@gaelicWizard gaelicWizard deleted the themes_autosave branch September 17, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants