Delete .shellcheckrc
#1947
Merged
Delete .shellcheckrc
#1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
shellcheckrc
branch
from
0a4ebe3
to
aaaae4d
Compare
|
@NoahGorny, can you take a look at this one? I'd like to get this merged before I do anything else. |
gaelicWizard
force-pushed
the
shellcheckrc
branch
10 times, most recently
from
2b081e0
to
9c57ed5
Compare
|
Hi @gaelicWizard- great work! |
gaelicWizard
force-pushed
the
shellcheckrc
branch
2 times, most recently
from
8cf1e89
to
ecfbb2d
Compare
NoahGorny
requested changes
Sep 16, 2021
NoahGorny
approved these changes
Sep 16, 2021
Declare `locals` at the top of the function
Match the style of the existing code
gaelicWizard
force-pushed
the
shellcheckrc
branch
from
65aea49
to
6ce9911
Compare
We assign a large number of variables here and they may or may not be used anywhere else, so disable SC2034 for this file (only). Alsö disable SC2005 as the functions in this file were written before `printf` was invented and have to do some fancy metascripting to get escape sequences interpreted reliably. I’m not smart enough to fix this to use `printf`, so leave it for now.
Each one of these themes will need it’s own fix for SC2154, possibly upstream. Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.
Each one of these themes will need it’s own fix for SC2154, possibly upstream. Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.
gaelicWizard
force-pushed
the
shellcheckrc
branch
from
6ce9911
to
5023b20
Compare
6 tasks
catull
pushed a commit
to catull/bash-it
that referenced
this pull request
Oct 21, 2021
* CI: disable Ubuntu 16.04 as it's EOL https://github.blog/changelog/2021-04-29-github-actions-ubuntu-16-04-lts-virtual-environment-will-be-removed-on-september-20-2021/ * main: lint false positive * install: lint * plugins/cmd-returned-notify: don't `export` * plugins/xterm: lint * plugins/git: lint * plugins/goenv: lint * plugins/alias-completion: lint false positives * plugins/alias-completion: fix SC2155, SC2154 Declare `locals` at the top of the function * completion: lint completions using `bash_completion` functions Match the style of the existing code * completion/knife: lint false positives * completion/knife: lint * completion/sdkman: lint * completion/composer: lint * Move `.shellcheckrc` under `themes/` * lib/theme: fix SC2155, SC2154, SC2034 * lib/colors: don't warn on unused variables We assign a large number of variables here and they may or may not be used anywhere else, so disable SC2034 for this file (only). Alsö disable SC2005 as the functions in this file were written before `printf` was invented and have to do some fancy metascripting to get escape sequences interpreted reliably. I’m not smart enough to fix this to use `printf`, so leave it for now. * themes/agnoster: lint * themes: disable SC2154 for colors Each one of these themes will need it’s own fix for SC2154, possibly upstream. Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules. * themes: disable SC2154, fix SC2155 Each one of these themes will need it’s own fix for SC2154, possibly upstream. Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules. * Delete `.shellcheckrc` * remove executable bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out that there is a file in the repo root which disabled checks for unbound variables. This fixes #1923.
Motivation and Context
I've done a lot of work finding and fixing these problems...which would have been detected by shellcheck if it hadn't been disabled.
shellcheckto detect because the theme doesn't use what it sets, but the prompt does.nounset, and loud errors withnounsetSince my
unboundbranch was already merged, there's only a couple that are missing SC2154 (from already-linted files). I've alsö disabled SC2034 in the colors lib, since that file is basically entirely that and SC2005.I've alsö gone through and fixed the CI linter for already-linted themes, plugins, and completions, with the exception of unbound parameters in themes. For the themes, I've just disabled the message to be fixed later.
How Has This Been Tested?
I've run
shellcheckmyself. All CI tests pass, CI linter passes, CI formatter comes back clean.Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.