-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin/ruby shellcheck
#1955
plugin/ruby shellcheck
#1955
Conversation
shellcheck
45ff096
to
778b65e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings !
The fixes to the ruby plugin seems mostly legit. Always glad to get more files into the clean_files.txt
!
I have one comment on the "${1?}"
usage.
Also, what are the empty files in this PR? Permission changes? They don't seem releveant to this PR.
If this is a stacked PR waiting on another PR to merge first, then lets label it DRAFT for now ...
778b65e
to
8a81fd7
Compare
I always mark it a draft in the GitHub UI and add "DRAFT" to the title until it's parent branch is approved. I've just rebased this on master and it's now ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best I can tell this looks baked and ready to go !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Great work @gaelicWizard and great review @davidpfarrell 😄
Description
Quote some things and handle unbound parameters.
Motivation and Context
This was part of my
_command_exists
branch (#1938) but was out of scope.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.