Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip go tests when go is not available #1967

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

cornfeedhobo
Copy link
Member

@cornfeedhobo cornfeedhobo commented Sep 29, 2021

Description

Similar to the goenv plugin, we have to test for go's actual existence
for users with goenv and no system-installed go.

Bonus: remove the $CI check that is a relic from Travis CI days.

Motivation and Context

I stumbled into this when running tests locally.

How Has This Been Tested?

locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @cornfeedhobo

@cornfeedhobo cornfeedhobo merged commit 07384bc into Bash-it:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants