Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/jekyll: lint and stuff #1969

Merged
merged 4 commits into from
Jan 1, 2022
Merged

Plugin/jekyll: lint and stuff #1969

merged 4 commits into from
Jan 1, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Oct 10, 2021 •
edited
Loading

Description

Run shellcheck, shfmt, and then try to clean up a bit.

Motivation and Context

No behavior changes intended with one exception: source ~/.jekyllconfig is moved from main to the Jekyll plugin.

How Has This Been Tested?

Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review October 10, 2021 08:15
@gaelicWizard gaelicWizard force-pushed the plugin-jekyll branch 4 times, most recently from 114c98a to 321aff6 Compare October 13, 2021 05:33
NoahGorny
NoahGorny approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always like cleanup PRs 😄

@gaelicWizard
plugin/jekyll: shfmt && shellcheck
1c3a7ff 
Use bashisms, remove suplerfous variable, use parameter default value replacement
@gaelicWizard
main: move Jekyll stuff to plugins/jekyll
c0aad51 
If the user doesn't load the Jekyll plugin, then don't load any Jeykll stuff.
@gaelicWizard
plugin/jekyll: second shellcheck pass
e38eeef
@gaelicWizard
plugin/jekyll: try to shorten the flow
3fe9c8d 
Alsö, use `pushd`/`popd` instead of `builtin cd`.

Alsö, SC2153
@gaelicWizard
Copy link
Contributor Author

Anything else needed for this PR?

@NoahGorny NoahGorny merged commit f534505 into Bash-it:master Jan 1, 2022
@gaelicWizard gaelicWizard deleted the plugin-jekyll branch January 1, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny