lib/utilities: minor improvements #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
utilities
branch
3 times, most recently
from
8718812
to
2d97377
Compare
alsö fix usage example of `_bash-it-array-contains-element()`
gaelicWizard
force-pushed
the
utilities
branch
from
2d97377
to
3cde6ef
Compare
No need to `rm` when we overwrite the file the line after next. Alsö, use `>|` in case the user sets `noclobber`; we do expressly intend to overwrite the file in this case.
gaelicWizard
force-pushed
the
utilities
branch
from
3cde6ef
to
b1f3e79
Compare
NoahGorny
approved these changes
Oct 17, 2021
There was a problem hiding this comment.
Great work @gaelicWizard
Can you please remove the direct mention of my username in 1601ea7?
Just remove the "@" so it wont spam me every time somebody will fork/rebase
Ummm....oops! Fixed! Alsö, fixed a typo in another commit note. |
gaelicWizard
force-pushed
the
utilities
branch
from
b1f3e79
to
2d1b2f9
Compare
Use $XDG_CACHE_HOME environment constant instead of placing a tmp/cache folder inside the bash-it data repo. If not defined, fall back to current behavior. This resolves Bash-it#1904.
Doesn't show up on my shellcheck 0.7.2, but does for NoahGorny!
The existing function `_bash-it-grep()` is weird. New function `_bash-it-egrep()` just does the thing without requiring two subshells and manual invocation.
gaelicWizard
force-pushed
the
utilities
branch
from
2d1b2f9
to
253d121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit notes as appropriate.
Description
Some minor improvements to
lib/utilities:_bash-it-array-dedup()$XDG_CACHE_HOMEfor cache fileMotivation and Context
Just cleaning up
How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.