Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save-and-reload-history command not found #1975

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix save-and-reload-history command not found #1975

merged 1 commit into from
Oct 18, 2021

Conversation

krapshsa
Copy link
Contributor

The function save-and-reload-history is not exists.
Use _save-and-reload-history instead of save-and-reload-history.

Description

When I set BASH_IT_THEME='powerline',
it will show save-and-reload-history: command not found every time after starting a new command.
I found that other scripts use _save-and-reload-history instead of save-and-reload-history,
so I replace it with _save-and-reload-history.

Motivation and Context

It fixes "command not found."

How Has This Been Tested?

  1. Set export BASH_IT_THEME='powerline in ~/.bashrc.
  2. source ~/.bashrc
  3. Press enter or some command.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Contributor

@gaelicWizard gaelicWizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @krapshsa!
Thanks for the bugfix 😄

@NoahGorny NoahGorny merged commit 2d1bd82 into Bash-it:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants