Themes: shellcheck (SC2154); Part B
#1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
themes-SC2154-B
branch
2 times, most recently
from
ed0cbb8
to
e71149f
Compare
gaelicWizard
force-pushed
the
themes-SC2154-B
branch
from
e71149f
to
9e9cfec
Compare
|
This PR is ready for review and merge. |
gaelicWizard
force-pushed
the
themes-SC2154-B
branch
from
9e9cfec
to
d16c106
Compare
gaelicWizard
force-pushed
the
themes-SC2154-B
branch
from
d16c106
to
a7f6f14
Compare
Use `[[` instead of `[`, set some local variables, still more to clean
Handle all unbound parameters, even colors!
Handle all unbound parameters, even colors!
Handle all unbound parameters, even colors!
gaelicWizard
force-pushed
the
themes-SC2154-B
branch
from
a7f6f14
to
fcbe4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit notes as appropriate.
Description
This is a chunk of my
SC2154branch (#1954), hopefully small enough to merge quickly, but slightly more changes than #1977.Motivation and Context
I think the changes here should be without behavior changes. There's some very slight refactoring with subshells, but really this is intended to be simple and similar changes across all these files.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.