Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Fix doubletime_multiline scm_prompt #1987

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

mikejamestx
Copy link
Contributor

Fix errors in doubletime_multiline and doubletime_multiline_pyonly themes caused by missing doubletime_scm_prompt function.

Description

Replace calls to doubletime_scm_prompt with scm_prompt within prompt_setter

Motivation and Context

The doubletime_scm_prompt function was removed in favor of scm_prompt in commit dff892e. This caused the doubletime_multiline and doubletime_multiline_pyonly themes to raise errors when generating prompts.

How Has This Been Tested?

Manually tested on Ubuntu 20.04 (WSL) and on CentOS 7

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Replace doubletime_scm_prompt with scm_prompt.
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder how these got missed at the time of the conversion?

Changes seem to match original changes made to doubletime.theme.bash, sooo

Approved and thanks !

@NoahGorny NoahGorny merged commit 036cf8a into Bash-it:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants