Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alias ls='ls -F' #1991

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Added alias ls='ls -F' #1991

merged 3 commits into from
Jan 7, 2022

Conversation

noviicee
Copy link
Contributor

@noviicee noviicee commented Dec 2, 2021

Description

Added the option -F in alias ls.

Motivation and Context

closes #1206

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@noviicee
Copy link
Contributor Author

noviicee commented Dec 2, 2021

Kindly let me know if any changes are required. I'll be happy to do so. This is my first PR :)

davidpfarrell
davidpfarrell suggested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending back for changes ...

aliases/available/general.aliases.bash Outdated Show resolved Hide resolved
aliases/available/msys2.aliases.bash Outdated Show resolved Hide resolved
@noviicee
Copy link
Contributor Author

Okay. Will fix it by tomorrow 👍

@gaelicWizard
Copy link
Contributor

I like -F and support including it here

@NoahGorny
Copy link
Member

gentle ping @noviicee

@noviicee
Copy link
Contributor Author

noviicee commented Jan 3, 2022

So sorry for the delay. Changing the alias name immediately.

davidpfarrell
davidpfarrell approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks !

@NoahGorny NoahGorny merged commit b846c86 into Bash-it:master Jan 7, 2022
@noviicee noviicee deleted the issue-1206 branch January 7, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpfarrell davidpfarrell davidpfarrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommended to add the option -F in alias ls
4 participants
@noviicee @gaelicWizard @NoahGorny @davidpfarrell