Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/todo: cleanup and simplify #2005

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Plugin/todo: cleanup and simplify #2005

merged 2 commits into from
Jan 7, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Clean up plugin/todo, add to clean_files.txt, and use _bash-it-component-item-is-enabled() in plugin/base.

Motivation and Context

Mostly just cleaning up, but alsö getting rid of that abomination in plugin/base.

How Has This Been Tested?

Tests pass locally and in CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard changed the title Ling: plugin/todo Lint: plugin/todo Dec 29, 2021
@gaelicWizard gaelicWizard marked this pull request as ready for review December 29, 2021 17:58
@gaelicWizard gaelicWizard force-pushed the plugin-todo branch 4 times, most recently from 4a0871d to 174afba Compare December 31, 2021 06:59
@gaelicWizard gaelicWizard changed the title Lint: plugin/todo Plugin/todo: cleanup and simplify Dec 31, 2021
@gaelicWizard
plugins/todo: lint
02b57a8 
plugin/base: use `_bash-it-component-item-is-enabled()`
@gaelicWizard
plugin/base: rewrite t() function to use todo.sh
d6bcedf 
Move the test for whether `plugin/todo` is enabled inside the function, and remove the alias from there.

Alsö, respect `$XDG_STATE_HOME` and move the old `~/.t` file if it exists.
NoahGorny
NoahGorny approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@NoahGorny NoahGorny merged commit 48a1ff7 into Bash-it:master Jan 7, 2022
@gaelicWizard gaelicWizard deleted the plugin-todo branch January 7, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny