Plugin/Java: quote path and provide useful error message

[gaelicWizard]

Description

Quote the path to the JAR file in jar_manifest(), and provide a meaningful error message if no path is provided.

Motivation and Context

Just cleaning up; this function would fail for any files with spaces in the path. Alsö, shfmt.

Note: this branch alsö includes a fix to path quoting in test/run; otherwise tests wouldn't be able to run at all when $BASH_IT has a space in it.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[davidpfarrell]

Are these files related to the PR?:

• test/plugins/xterm.plugin.bats
• test/run

[gaelicWizard]

Are these files related to the PR?:

• test/plugins/xterm.plugin.bats
• test/run

Yes, I can't run BATS at all without fixing unquoted paths, so I can't run the test suite before submitting without those two fixes. I suppose I could pull them from this PR if you prefer

[davidpfarrell]

Yes, I can't run BATS at all without fixing unquoted paths, so I can't run the test suite before submitting without those two fixes. I suppose I could pull them from this PR if you prefer

Sounds like you want a separate PR to address running bats in environments that require quoted paths ...

[gaelicWizard]

Yes, I can't run BATS at all without fixing unquoted paths, so I can't run the test suite before submitting without those two fixes. I suppose I could pull them from this PR if you prefer

Sounds like you want a separate PR to address running bats in environments that require quoted paths ...

I did. It's one of my two dozen open PRs. I'll pull those two commits from this PR if you prefer

[davidpfarrell]

I did. It's one of my two dozen open PRs. I'll pull those two commits from this PR if you prefer

Can you reference it? I took a quick look at open PRs and didn't recognize it (by name) ...

We can consider this a draft and get that other PR merged at which point it should disappear from this PR ...

[davidpfarrell]

Approved !

[gaelicWizard]

Can you reference it? I took a quick look at open PRs and didn't recognize it (by name) ...

My BATS fixes are currently consolidated under #2002.

EDIT: and has been part of my shellcheck branch (#1917) since October 19th.