Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin/LaTeX: 2009 was thirteen years ago #2007

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Dec 30, 2021

Description

This plugin was hard-coded for the 2009 edition of MacTeX. I am 99.999999% sure literally zero people use this plugin, since it hasn't done anything in over a decade.

Motivation and Context

Now, it will attempt to locate the currently installed edition of MacTeX and add it to the path.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the plugin-latex branch 2 times, most recently from 37b9c60 to 0845eab Compare December 30, 2021 19:27
@gaelicWizard gaelicWizard marked this pull request as ready for review December 30, 2021 19:29
@gaelicWizard gaelicWizard force-pushed the plugin-latex branch 2 times, most recently from 936c5d6 to 6cc6713 Compare January 2, 2022 01:49
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think we can just get rid of this plugin altogether, does not seem that useful anyway

@gaelicWizard
Copy link
Contributor Author

Honestly I think we can just get rid of this plugin altogether, does not seem that useful anyway

Since it hasn't worked in over a decade, it would be a breaking change in name only.

Locate the currently installed edition, instead of transpoting us back to undergrad.
@NoahGorny NoahGorny merged commit 1fd601d into Bash-it:master Jan 8, 2022
@gaelicWizard gaelicWizard deleted the plugin-latex branch January 8, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants