Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin/man: Add R to $LESS #2009

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Dec 31, 2021

Description

Add R to $LESS, which is interpreted as flags on the command line. Alsö, don't clobber user-set variables.

Motivation and Context

Otherwise, -R must be added on the command line or colors just won't be rendered and these variables will be ignored. Usually, less gets aliased or wrapped in a function, but if it's not then we'd like to use our settings. This alsö reduces the need to alias or wrap less and is much less likely to break.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review December 31, 2021 07:42
@gaelicWizard gaelicWizard changed the title plugins/man: Add "R" to $LESS plugins/man: Add R to $LESS Dec 31, 2021
@gaelicWizard gaelicWizard changed the title plugins/man: Add R to $LESS Plugin/man: Add R to $LESS Dec 31, 2021
Otherwise, `-R` must be added on the command line or colors just won't be rendered and these variables will be ignored.
Don't overwrite variables that the user has already set.

plugins/man: unbound `$LESS`
@NoahGorny NoahGorny merged commit dba610c into Bash-it:master Jan 7, 2022
@gaelicWizard gaelicWizard deleted the plugin-man branch January 7, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants