Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme/essential: cleanup #2012

Merged
merged 4 commits into from
Jan 7, 2022
Merged

theme/essential: cleanup #2012

merged 4 commits into from
Jan 7, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Handle unbound parameters, even colors! Alsö, shfmt.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard changed the title Theme/essential theme/essential: cleanup Jan 1, 2022
@gaelicWizard gaelicWizard marked this pull request as ready for review January 1, 2022 08:09
NoahGorny
NoahGorny approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@gaelicWizard
theme/essential: SC2154
9f79848 
Handle all unbound parameters, even colors!
@gaelicWizard
theme/essential: shfmt
d1b7166
@gaelicWizard
theme/essential: cleanup
3695862 
Lose a couple of useless `echo`s/subshells.

Alsö, lose the incorrect VIM modeline from the bottom. Our formatting standard is specified in `$BASH_IT/.EditorConfig`.
@gaelicWizard
theme/essential: s/echo/printf/g
f2dcb2a
@NoahGorny NoahGorny merged commit 2728f20 into Bash-it:master Jan 7, 2022
@gaelicWizard gaelicWizard deleted the theme/essential branch January 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny