Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion/system: load earlier than others #2013

Merged
merged 3 commits into from
Jan 8, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Set BASH_IT_LOAD_PRIORITY to 325 so that the distro-provided bash-completions package is loaded before any other completions packaged here.

Motivation and Context

Several of the completions bundled in Bash It test whether another completion is already installed, however system sorts lexicographically fairly late in the alphabet so it is unlikely that our tests are succeeding. I chose 325 so that it's still possible to deliberately place something before this component, if needed somehow.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review January 2, 2022 06:41
@gaelicWizard gaelicWizard force-pushed the completion/system branch 2 times, most recently from 994ee98 to b42bb30 Compare January 6, 2022 06:52
@NoahGorny
Copy link
Member

Hi @gaelicWizard, lets maybe add system.completion.bash into clean_files.txt if we are already touching it?

@gaelicWizard
Copy link
Contributor Author

@NoahGorny, I'm simply not able to keep track of so many unmerged branches. I'm doing my best to split these things out so they can be merged piecemeal.

I chose `325` so that it's still possible to deliberately place something *before* this component, if needed somehow.
My apologies to future `git blame` hunters ♥
@NoahGorny NoahGorny merged commit f2bff34 into Bash-it:master Jan 8, 2022
@gaelicWizard gaelicWizard deleted the completion/system branch January 8, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants