lib/colors: split out metaprogramming #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
lib/colors
branch
3 times, most recently
from
8ea9d8c
to
1b3c86b
Compare
NoahGorny
reviewed
Jan 7, 2022
gaelicWizard
force-pushed
the
lib/colors
branch
from
1b3c86b
to
07d13c5
Compare
gaelicWizard
force-pushed
the
lib/colors
branch
6 times, most recently
from
099b9d5
to
621db6c
Compare
gaelicWizard
force-pushed
the
lib/colors
branch
3 times, most recently
from
03a8260
to
fd212c5
Compare
This reverts Bash-it#99, a metaprogramming adventure in terminal color code escape computation. It was functionally reverted in Bash-it#699; I'm just finishing the job.
This reverts commit 2a3fde2 but does *not* restore the previous variables. Those are still provided by `lib/colors`. This plugin exists for anyone who likes the metaprogramming adventure of computing colors dynamically rather than using hard-coded value. Potentially this could be used by themes, or possibly by a theme color-scheme randomizer?
gaelicWizard
force-pushed
the
lib/colors
branch
from
fd212c5
to
85a77f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #99, an advanced method for computing color code escape sequences was committed to allow generation of any combination of text attributes: bold, underline, color, background color, &c. In #699, it was reverted for wasting a lot of time at every shell startup computing the same colors every time. Now, this PR splits the file in to two:
lib/colorswhich contains the color codes used by Bash It, andplugin/colorswhich contains the metaprogramming color-escape computation engine.Motivation and Context
The whole file was just hard to understand until I stumbled across the commits that made it that way...and the commit that removed it. This change has zero changes to the code as run, just separates the meta from the utility.
git mergeso that the new files both show history back throughthemes/colors.theme.bash.bash-it enable plugin colors.plugin/colorsframework could actually be used to run tests againstlib/colors, to make sure that the colors precomputed match the colors generated. That sounds fun...said no-one ever...(I'm a nerd, ok?)How Has This Been Tested?
Tested locally and full test suite passes.
Types of changes
bash-it enable plugin colors)Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.