-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BATS infra refactor #2031
Merged
Merged
BATS infra refactor #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c897ff
to
df2362f
Compare
b86c32a
to
0b03ee2
Compare
3e58a5f
to
86af804
Compare
Run the test *files* in parallel, but not the tests *within* the files. This can be reverted after configuration (i.e., `$BASH_IT/enabled` et al) lives *outside* the repo.
test/uninstall: adopt newly revamped `setup()` test/install: `local_setup_file()`
c9270b9
to
a9dda3d
Compare
@NoahGorny, I didn't realize #2061 was already merged! Rebased on master (with no conflicts) and ready to roll 😃 |
NoahGorny
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_helper.bash
,git worktree
for a fast, reliable, and predictable test environment,test_make
,$HOME
or local$BASH_IT
,bats-core
to tagv1.5.0
.I believe this closes #1821.
Motivation and Context
This is chapter 2 of my last BATS patch. This time I understand BATS slightly better!
I disabled intra-file parallelization, but this can be reverted as soon as configuration is no longer inside the repo.
This alsö should resolve the drive behind #1753, as the test environment is now separated from the live repository.
How Has This Been Tested?
Lots and lots of running
test/run
...Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.