Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme/brunton: shellcheck #2037

Merged
merged 1 commit into from
Jan 25, 2022
Merged

theme/brunton: shellcheck #2037

merged 1 commit into from
Jan 25, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 12, 2022 •
edited

Description

Handle all unbound parameters, even colors!

Motivation and Context

Simplicity, consistency, and #1696.

How Has This Been Tested?

bash-it preview brunton

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard
theme/brunton: SC2154
27ebc58 
Handle all unbound parameters, even colors!
@gaelicWizard gaelicWizard marked this pull request as ready for review January 12, 2022 21:43
@gaelicWizard gaelicWizard changed the title theme/brunton: SC2154 theme/brunton: shellcheck Jan 13, 2022
@NoahGorny
Copy link
Member

Hi @gaelicWizard, dont forget to add the file to clean_files.txt
Otherwise it might be clobbered in a future PR!

@gaelicWizard
Copy link
Contributor Author

@NoahGorny, it already is! 😃

NoahGorny
NoahGorny approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct

@NoahGorny NoahGorny merged commit 44a1b55 into Bash-it:master Jan 25, 2022
@gaelicWizard gaelicWizard deleted the theme/brunton branch January 25, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny