Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliases: lint the entire folder #2047

Merged
merged 10 commits into from
Feb 16, 2022
Merged

Aliases: lint the entire folder #2047

merged 10 commits into from
Feb 16, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 16, 2022 •
edited

Description

  • shfmt
  • shellcheck
  • fix a few straglers

Motivation and Context

Although this touches 48 files:

  • 30 of them are just the file headers,
  • 12 of them are just headers and whitespace,
  • and the last six are all trivial fixes.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the alias/shfmt branch 2 times, most recently from bc4cadc to fd79b12 Compare January 16, 2022 21:24
@gaelicWizard gaelicWizard marked this pull request as ready for review January 16, 2022 21:28
@gaelicWizard gaelicWizard changed the title Alias: lint the entire folder Aliases: lint the entire folder Jan 16, 2022
gaelicWizard
gaelicWizard commented Jan 17, 2022
View reviewed changes
Copy link
Contributor Author

@gaelicWizard gaelicWizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this touches 48 files:

  • 30 of them are just the file headers,
  • 12 of them are just headers and whitespace,
  • and the last six are all trivial changes.

@gaelicWizard gaelicWizard force-pushed the alias/shfmt branch 3 times, most recently from 9f363ba to f8c2149 Compare January 31, 2022 00:12
@gaelicWizard gaelicWizard mentioned this pull request Feb 8, 2022
Closed
8 tasks
@gaelicWizard gaelicWizard force-pushed the alias/shfmt branch 2 times, most recently from c3bad49 to ecb2437 Compare February 12, 2022 08:26
@NoahGorny
Copy link
Member

there appears to be some failing lint somewhere, I will be happy to merge this after it gets fixed :)

@gaelicWizard
Copy link
Contributor Author

@NoahGorny, fixed to use single-quotes 👍

NoahGorny
NoahGorny approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahGorny NoahGorny merged commit 187916d into Bash-it:master Feb 16, 2022
@gaelicWizard gaelicWizard deleted the alias/shfmt branch February 16, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny