Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/reloader: lint and modernize #2055

Merged
merged 3 commits into from
Jan 29, 2022
Merged

lib/reloader: lint and modernize #2055

merged 3 commits into from
Jan 29, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 19, 2022 •
edited

Description

  • adopt _bash-it-log-prefix-by-path(),
  • shfmt,
  • shellcheck,

Motivation and Context

Trying to get this thing to run with spaces in path...

How Has This Been Tested?

This has been part of my main branch since September...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the lib/reloader branch 3 times, most recently from 0b7e15b to d74eb33 Compare January 19, 2022 18:59
@gaelicWizard gaelicWizard marked this pull request as ready for review January 19, 2022 19:01
@gaelicWizard
Copy link
Contributor Author

Ok, this should be a fairly straightforward improvement for @Bash-it. I think this should be well inline with my other shellcheck fixes and hopefully uncontroversial. 😃

@gaelicWizard gaelicWizard changed the title lib/reloader: quote, shorten, de-loop lib/reloader: lint and modernize Jan 19, 2022
@gaelicWizard
Copy link
Contributor Author

Rebased on current master and ready to go!

NoahGorny
NoahGorny approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaelicWizard gaelicWizard force-pushed the lib/reloader branch 2 times, most recently from d05ef38 to d12e4e2 Compare January 26, 2022 18:24
@gaelicWizard
lib/reloader: adopt _bash-it-log-prefix-by-path()
75d22d8
@gaelicWizard
reloader: shellcheck && shfmt
fd7b20b 
Rewrite globbing per `shellcheck`'s SC2013 recommendations, and standardize whitespace.
@NoahGorny NoahGorny merged commit 578c702 into Bash-it:master Jan 29, 2022
@gaelicWizard gaelicWizard deleted the lib/reloader branch January 29, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaelicWizard @NoahGorny