Tilde expanstion won't work once it is a quoted string, expanding in advance #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
approved these changes
Feb 11, 2022
NoahGorny
approved these changes
Feb 13, 2022
…fix-dirs * 'master' of https://github.com/Bash-it/bash-it: (22 commits) main: variable name cleanup lib/history: new functions `_bash-it-history-auto-*()` plugin/history*search: no need to load after `plugin/history` plugin/history-eternal: Use `readonly` instead of `export` plugin/history: don't use `export` lib/preview: add full completion lib/helpers: add `preview` to `bash-it` spaghetti lib/preview: refactor into a function completion/system: correctly load version when not linked main: adopt `_bash-it-log-prefix-by-path()` main: Glob for *.bash properly when path contains spaces completion/aliases: rename init function test/battery: require matching battery identifier test/battery: add multiple-battery edge case plugin/battery: split `upower` to two variables completion/alias: add stub file completion/alias: fix tests completion/alias: rename completion/alias: `shfmt` && `shellcheck` completion/alias: eliminate use of `eval` ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the "dirs" plugin expected a tilde to be expanded even though the path is a quoted string, and that fails, I get it to expand $HOME instead.
Motivation and Context
opening a new shell kept giving me errors about the file not existing
How Has This Been Tested?
variable unset and bashit reloaded, error message gone.
Screenshots (if appropriate):
Types of changes
Checklist: