Add a 'theme' for OMP, so the internal themes don't clash with it. #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…omp-theme * 'master' of https://github.com/bash-it/bash-it: Fix knife completion (Bash-it#2098) plugin/battery: fix tests Remove executable bit. lib/helpers: `_bash-it-find-in-ancestor()` lib/utilities: `_bash-it-component-item-is-enabled()` lib: rename `_bash-it-clean-component-cache()` lib/utilities: use `$XDG_CACHE_HOME` properly lib/utilities: `_bash-it-component-item-is-enabled()` lib/utilities: >| lib/helpers: fix extraneous quotes from `_bash-it-grep()` bash-it update: show change log once lib/theme: handle undefined parameter lib/helpers: the last remnants of the `$OSTYPE` have been swept away lib/search: fix variable scope lib/helpers: handle unbound parameters lib/helpers: cleanup `_bash-it-profile-load-parse-profile()` a bit lib/helpers: handle unbound positional parameters fix wrong function name in `helpers.bash`
…omp-theme * 'master' of https://github.com/bash-it/bash-it: (52 commits) lib/command_duration: tests & whitespace lib/command_duration: adopt `_bash_it_library_finalize_hook` lib/command_duration: rename `theme/command_duration.theme` plugin/cmd-returned-notify: Rewrite to match/use `lib/command_duration` lib/command_duration: Refactor using `$EPOCHREALTIME` lib/command_duration: dynamic clock hand lib/command_duration: remove temporary files lib/appearance: export `$CLICOLOR` instead of `$LSCOLOR` lib/appearance: `shellcheck` && `shfmt` plugin/battery: fix handling of multiple batteries with `upower` Revert dc380e9 test/battery: fix tests… test/base: lose old TravisCS skip lib/theme: use `_command_exists()` in `rbenv_version_prompt()` lib/theme: `local hg_root` in `hg_prompt_vars()` lib/theme: improve performance of `scm()` lib/theme: export `$LS_COLORS` et al lib/theme: parameter cleanup lib/theme: eliminate a lot of subshells lib/theme.githelpers: remove dead code ...
gaelicWizard
approved these changes
Mar 6, 2022
DaiTengu
pushed a commit
to DaiTengu/bash-it
that referenced
this pull request
Mar 9, 2022
…ash-it#2100) * Add a 'theme' for OMP, so the internal themes don't clash with it. * Add theme to clean_files * Add screenshot to the docs * Correct the name of the default theme in the docs. * keeping it cleaner Co-authored-by: Ira Abramov <github@ira.abramov.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
oh-my-posh is a shell theme tool written in golang, and invoking it clashes with the internal themes of bash-it, so this is my proposed way of integrating them.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
see #2099
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.