Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic clock icon #2120

Merged

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Mar 9, 2022

Description

UTF8 clock value can be set between 90 and 9b in hexadecimal.
The current code was between 90 and 101.

Motivation and Context

Clock icon was not correct for certain value.

How Has This Been Tested?

for second in {1..15}; do
    clock_hand=$(printf '%x' $(((${1:-${second}} % 12) + 144)))
    printf '%b' "\xf0\x9f\x95\x$clock_hand"
done

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Contributor

@tbhaxor tbhaxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/command_duration.bash Outdated Show resolved Hide resolved
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the actual usefulness of the feature is still in question, I think this PR does actually fix the bug - nice catch!

@NoahGorny NoahGorny merged commit e1ddf6e into Bash-it:master Mar 9, 2022
DaiTengu pushed a commit to DaiTengu/bash-it that referenced this pull request Mar 9, 2022
* Fix dynamic clock icon

* Use printf variable scope

* shfmt do not like spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants