Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean flutter completions #2135

Merged
merged 2 commits into from
May 18, 2022
Merged

Clean flutter completions #2135

merged 2 commits into from
May 18, 2022

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Mar 15, 2022

Description

Formats the file with shfmt

Motivation and Context

Clean bashit from #1696

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

cornfeedhobo
cornfeedhobo approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@cornfeedhobo cornfeedhobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple. Thanks!

cornfeedhobo
cornfeedhobo requested changes May 5, 2022
View reviewed changes
Copy link
Member

@cornfeedhobo cornfeedhobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you still have a failing test. Blocking because I approved to quickly.

@tbhaxor
Copy link
Contributor Author

tbhaxor commented May 5, 2022

Looks like you still have a failing test. Blocking because I approved to quickly.

Seems like this issue is not fixed yet. @NoahGorny did you manage to find the fix?

@tbhaxor tbhaxor force-pushed the improve/flutter-completion branch from 4655ba6 to e11576f Compare May 6, 2022 18:06
NoahGorny
NoahGorny approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tbhaxor !

@NoahGorny NoahGorny merged commit 2ef5d48 into Bash-it:master May 18, 2022
@tbhaxor tbhaxor deleted the improve/flutter-completion branch May 18, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cornfeedhobo cornfeedhobo cornfeedhobo requested changes

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbhaxor @cornfeedhobo @NoahGorny