Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitlab Runner images #2154

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

jakebman
Copy link
Contributor

Description

Github deprecated and will remove two runner images.

macos-10.15 will be removed on 2022-08-30
macos-12 is available
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

ubuntu-18.04 will be removed on 2022-12-01
ubuntu-22.04 is available
https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

Motivation and Context

I found this detail while investigating intermittent macos test failures. This doesn't appear to be the cause of my issues, but it seems important information to share.

How Has This Been Tested?

This configuration successfully built on my fork's CI:
https://github.com/jakebman/bash-it/actions/runs/2848395734

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Contributor

@tbhaxor tbhaxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @NoahGorny Look the error on macOS is fixed 😄

@tbhaxor
Copy link
Contributor

tbhaxor commented Aug 13, 2022

@NoahGorny @gaelicWizard Please remove the macos-10.15 and ubuntu-18.04 from the branch protection.

Copy link
Member

@cornfeedhobo cornfeedhobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoahGorny @davidpfarrell This PR gets my sign off. Considering that everything is building fine, I think it should be fine to bypass the current restriction and merge.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakebman and thanks @tbhaxor @cornfeedhobo for the review

@NoahGorny NoahGorny merged commit d770030 into Bash-it:master Aug 17, 2022
@jakebman jakebman deleted the gitlab-runner-deprecation branch November 9, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants