Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): use correct escape sequence to avoid weird text overwriting #2170

Merged

Conversation

Royalsspirit
Copy link

Description

This branch will fix the parrot theme ps1 escape sequences in parse_git_branch which occur some text overwritting in alacritty terminal. (i had this issue in alacritty terminal but probably happens in other terminal).
I remplaced the escape sequences with correct ones.

Motivation and Context

As the ps1 seems to not be correctly ended, the termianl emulator lines was never ended to which occur a text overwriting

Screenshots (if appropriate):

example

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@Royalsspirit Royalsspirit force-pushed the fix/parrot-theme-escape-sequence branch from 041a65e to 9db814c Compare October 14, 2022 07:32
@Royalsspirit Royalsspirit force-pushed the fix/parrot-theme-escape-sequence branch from 3fefca1 to 7c77223 Compare October 14, 2022 07:44
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Royalsspirit

@NoahGorny NoahGorny merged commit cfe46e3 into Bash-it:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants