Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint 💚 #2213

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: lint 💚 #2213

merged 1 commit into from
Oct 2, 2023

Conversation

robertoschiavone
Copy link
Contributor

Description

This commit bumps go version to 1.21.0 and changes go get to go install.

Motivation and Context

Current workflow for PRs is broken because the tool that is invoked to format the code, shfmt, requires go >= 1.19.

How Has This Been Tested?

Workflow was launched again after fix and it doesn't fail anymore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@bittner
Copy link
Contributor

bittner commented Oct 1, 2023

Please merge this PR! - All new PRs are failing without this change, currently.

@hyperupcall
Copy link
Contributor

It looks like #2224 that I just made is similar - but I have also updated the GitHub actions that we use

@davidpfarrell
Copy link
Contributor

davidpfarrell commented Oct 2, 2023

For KISS reasons I think we should go with this one, but thank you all for taking the time to get this fixed !


cc: @robertoschiavone , @hyperupcall , @bittner

@hyperupcall
Copy link
Contributor

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

@davidpfarrell davidpfarrell merged commit df0e0af into Bash-it:master Oct 2, 2023
6 checks passed
@davidpfarrell
Copy link
Contributor

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

Yeah we can do that ... One Q on it (which I should have posted over there on it): Are the quotes needed? Although technically more correct, having some quoted and some non-quoted values feels less clean than current .... I would say leave unquoted unless needed

@hyperupcall
Copy link
Contributor

hyperupcall commented Oct 3, 2023

Yeah quotes in YAML aren't needed unless they're actually needed. I've heard too many near-death experiences from YAML that I have a habit of quoting everything I touch. But no worries I'll make the changes without quotes this time around (unless you want everything to be quoted, which seems unlikely)

@hyperupcall hyperupcall mentioned this pull request Oct 3, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants