Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Tools Profile. #622

Merged
merged 1 commit into from Dec 7, 2015

Conversation

billmoritz
Copy link
Contributor

@edubxb
Copy link
Member

edubxb commented Dec 6, 2015

I think that the base plugin is not the correct place for this.

Check the AWS plugin please.

@billmoritz
Copy link
Contributor Author

If thats true then I don't understand the design pattern. Especially when you take a look at battery_char() which is defined in base. If someone includes battery_char() in a theme and the plugin isn't there it returns nothing. If I was to define aws_profile() in the plugin and a theme used it without having the plugin enabled, you would get an error every prompt.

@nwinkler
Copy link
Member

nwinkler commented Dec 7, 2015

I think the base theme is the right place for this. @edubxb, did you confuse the base theme (where @billmoritz added this change) with the base plugin? I agree that the base plugin wouldn't be the right location, but since this is primarily going to be used in themes, the base theme looks like the right location for this functionality.

@edubxb
Copy link
Member

edubxb commented Dec 7, 2015

@nwinkler you're right, I confused the base theme with the base plugin 😅

@nwinkler
Copy link
Member

nwinkler commented Dec 7, 2015

@edubxb Don't worry - I had to look twice as well to see the difference...

nwinkler added a commit that referenced this pull request Dec 7, 2015
@nwinkler nwinkler merged commit bab76a5 into Bash-it:master Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants