This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Remove optional dependency on JetBrains Shell. #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we depend on it our completion tests fail (among others), as the Shell plugin is also contribution completions and more. Fixing this in gradle is non trivial as we'd had to extract the sources referencing shell into a new source dir and modify the build only when tests are run. We're now referencing the ShFileType by name and not by reference to avoid the dependency on the plugin. This was the only reference to code of the Shell plugin.
which may change in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we depend on it our completion tests fail (among others), as the Shell plugin is also contributes completions and more.
We're now checking for the
ShFIleTypeby simple class name.Fixing this in gradle is non trivial as we'd had to extract the sources referencing
shell into a new source dir and modify the build only when tests are run without affection the sourceDirs when a production build is created.
The other changes in this PR are reverting the previously applied changes to Gradle, which were insufficient.
We're now referencing the
ShFileTypeby name and not by reference to avoid the dependency on the plugin. This was the only reference to code of the Shell plugin.