Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dilemma 3x5+3 configs. #42

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Update Dilemma 3x5+3 configs. #42

merged 6 commits into from
Apr 5, 2023

Conversation

casuanoob
Copy link
Collaborator

@casuanoob casuanoob commented Apr 2, 2023 •
edited

RGB

  • Fix Key Matrix to LED index.
  • Fix LED index to physical position.
  • Add defines to enable RGB framebuffer animations and other new animations

Via Keymap

  • Increment USB PID for Via compatibility
  • Add encoder configs to config.h
  • Add bool encoder_update_kb function in 3x5_3.c
  • Add via keymap (with encoder_map)
  • Add bootmagic config for right half
  • Remove Auto Pointer Layer custom feature

@casuanoob
add encoder support to Dilemma 3x5_3
9444651
@casuanoob
port Via keymap to Dilemma 3x5_3
68c5a51 
Copied from 3x5_2 via keymap.

Added support for ENCODER_MAP feature for use with Via
@casuanoob casuanoob marked this pull request as ready for review April 4, 2023 12:50
0xcharly
0xcharly reviewed Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@0xcharly 0xcharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @casuanoob! Looking good!

keyboards/bastardkb/dilemma/3x5_3/keymaps/via/config.h Show resolved Hide resolved
keyboards/bastardkb/dilemma/3x5_3/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/bastardkb/dilemma/3x5_3/rules.mk Show resolved Hide resolved
keyboards/bastardkb/dilemma/3x5_3/rules.mk Show resolved Hide resolved
keyboards/bastardkb/dilemma/3x5_3/rules.mk Outdated Show resolved Hide resolved
keyboards/bastardkb/dilemma/3x5_3/keymaps/via/readme.md Outdated Show resolved Hide resolved
@casuanoob
make suggested changes
03dd992 
remove test keycodes from base layer
@0xcharly 0xcharly merged this pull request into Bastardkb:bkb-master Apr 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xcharly 0xcharly 0xcharly left review comments

Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casuanoob @0xcharly