scylla bg quick-fix: remove mention of rainbow #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we not instead enable that rgb animation by default in the Scylla vendor keymap? |
|
Yes, that would make sense - We probably should make sure the tbkmini and skeletyl follow suit as well (if they don't already have it) In the meantime, this might reduce confusion; We've already had two help threads about this. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scylla has no rgb effects beyond the default enabled, but the guide's testing section asks the user to look for a rainbow.
This quick-fix measure duplicates the testing include into the Scylla build guide and changes the wording to refer to the red effect.
Preview: https://finrod09.github.io/bastardkb.github.io/bg_scylla/10install_the_switches.html