Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused var and fix index vs id. #8

Merged

Conversation

clemens-tolboom
Copy link
Contributor

  • The initial OptionButton state versus selected is misaligned due to OptionButton.selected is by index but we set by id.
  • Variable p_id is never used.

@BastiaanOlij
Copy link
Owner

Oops, must have originally wanted to pass the id :)

@BastiaanOlij BastiaanOlij merged commit ab7a47f into BastiaanOlij:master Apr 22, 2021
@clemens-tolboom clemens-tolboom deleted the feature/fix-arg-and-index branch April 23, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants