Only set attributes if they're not null or undefined

Batterii · Feb 18, 2021 · bec21a9 · bec21a9
1 parent 50709e7
commit bec21a9
Show file tree

Hide file tree

Showing 3 changed files with 694 additions and 630 deletions.
diff --git a/docs/changelog/README.md b/docs/changelog/README.md
@@ -9,6 +9,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
+### Changed
+- Only set attributes if they're not null or undefined.
 
 
 ## [v2.3.0]

diff --git a/lib/attribute-assigner.ts b/lib/attribute-assigner.ts
@@ -77,10 +77,12 @@ export class AttributeAssigner<T> {
 
 		for (const name of attributeNames) {
 			const attribute = await this._get(name);
-			if (relationNames.includes(name)) {
-				await this.adapter.relate(this.evaluator.instance, name, attribute, this.model);
-			} else {
-				this.adapter.set(this.evaluator.instance, name, attribute);
+			if (attribute !== undefined && attribute !== null) {
+				if (relationNames.includes(name)) {
+					await this.adapter.relate(this.evaluator.instance, name, attribute, this.model);
+				} else {
+					this.adapter.set(this.evaluator.instance, name, attribute);
+				}
 			}
 		}