Merge pull request #135 from BayAreaMetro/acceptance-criteria-integra…

…tion

Transit Improvements and Acceptance Criteria Summaries

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,19 +1,25 @@
 ---
-name: Bug report
+name: 🐛 Bug report
 about: Create a report to help us improve
-title: "[BUG] Description of problem"
+title: "🐛 Bug: "
 labels: bug
 assignees: ''
-
 ---
 
 ## Describe the bug
-
-A clear and concise description of what the bug is or the error code you got. e.g.
-
-```python
+<!--A clear and concise description of what the bug is or the error code you got. e.g. 
+```python 
 KeyError: 'Passing list-likes to .loc or [] with any missing labels is no longer supported, see https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#deprecate-loc-reindex-listlike'
 ```
+-->
+
+Progress:
+
+- [ ] Sufficient information provided
+- [ ] Cause identified/found
+- [ ] Test developed/identified 
+- [ ] Approach determined 
+- [ ] Test passes
 
 ## To Reproduce
 
@@ -27,7 +33,7 @@ Steps to reproduce the behavior:
 ### Failing tests
 
 - [ ] No applicable test failed, need to create.
-- [ ]
+- [ ] other...specify
 
 ### Triggering line of code
 

.github/ISSUE_TEMPLATE/chore_issue.md

@@ -0,0 +1,18 @@
+---
+name: 🧹 Chore
+about: Something that isn't a feature or a bug
+title: "🧹 Chore: "
+labels: chore
+assignees: ''
+---
+
+<!--Short Description-->
+
+Progress:
+
+- [ ] Sufficiently defined
+- [ ] Approach decided
+- [ ] Implemented
+
+## Considerations
+<!--Short Description-->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,37 +1,43 @@
 ---
-name: Feature request
-about: Suggest an idea for this project
-title: "[FEATURE]"
+name: 🚀 Feature request
+about: Suggest an enhancement
+title: "🚀 Feature:"
 labels: enhancement
 assignees: ''
-
 ---
-
 ### User Story
 
 *As a ...insert type of user... I'd like to ...insert desired feature or behavior...*
 
-### Priority
+Progress:
+
+- [ ] Sufficiently defined
+- [ ] Approach determined
+- [ ] Tests developed
+- [ ] User story satisfied
+- [ ] Doc strings
+- [ ] General documentation
+- [ ] Passing tests
+
+### Priority 
 
 ### Level of Effort
 
 ### Resolution Ideas
 
 ### Project
-
-*Is there a funder or project associated with this feature?*
+<!--Is there a funder or project associated with this feature?-->
 
 ### Who should be involved?
-
-Implementer:
-Commenters:
-Users:
-Reviewers:
+Users: 
+Reviewers: 
 
 ### Risk
-
-*Will this potentially break anything?*
+<!--Will this potentially break anything?-->
 
 #### Tests
+<!--What are relevant tests or what tests need to be created in order to determine that this issue is complete?-->
+
+- [ ] Test for...
+
 
-*What are relevant tests or what tests need to be created in order to determine that this issue is complete?*

.github/workflows/docs.yml

@@ -0,0 +1,20 @@
+name: Publish docs
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - develop
+
+jobs:
+  mkdocs:
+    name: Publish docs
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Deploy docs
+        uses: mhausenblas/mkdocs-deploy-gh-pages@master
+        env:
+          REQUIREMENTS: docs/requirements.txt
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/publish.yml

@@ -0,0 +1,32 @@
+# This workflow will upload a Python Package using Twine when a release is created
+# For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries
+
+name: Upload Python Package
+
+on:
+  release:
+    types: [created]
+
+jobs:
+
+  deploy:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python
+      uses: actions/setup-python@v2
+      with:
+        python-version: '3.7'
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install setuptools wheel twine
+    - name: Build and publish
+      env:
+        TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
+        TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
+      run: |
+        python setup.py sdist bdist_wheel
+        twine upload dist/*

.github/workflows/push.yml

@@ -6,6 +6,7 @@ jobs:
   build:
 
     runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, 'skip ci')"
     strategy:
       matrix:
         python-version: [3.8]
@@ -41,10 +42,10 @@ jobs:
     - name: Test with pytest
       run: |
         pytest -s -m "not skipci"
-    - name: Configure Git user
-      run: |
-        git config --local user.email "github-actions[bot]@users.noreply.github.com"
-        git config --local user.name "github-actions[bot]"
-    - name: Build docs
-      run: |
-        mike deploy --push --rebase ${{ github.ref_name }}
+    - name: Test documentation build
+      uses: Tiryoh/actions-mkdocs@v0
+      with:
+        mkdocs_version: 'latest' 
+        requirements: 'docs/requirements.txt' 
+        configfile: 'mkdocs.yml' 
+

.github/workflows/release_plan.yml

@@ -0,0 +1,33 @@
+name: Release Planning Milestone
+
+on:
+  milestone:
+    types: 
+      - created
+
+jobs:
+  create_issue:
+    name: Create Full Test with Emme Issue
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      MILESTONE:  ${{ github.event.milestone.number }}
+    steps:
+      - name: Create Full Test with Emme Issue
+        uses: imjohnbo/issue-bot@3daae12aa54d38685d7ff8459fc8a2aee8cea98b
+        with:
+          assignees: "flaviatsang"
+          labels: "test-run"
+          title: "Run Full Emme Tests for $MILESTONE"
+          body: |
+            ### Checklist
+
+            - [ ] Run full tests with Emme environment installed
+            - [ ] Generate bug issues for any failing tests
+            - [ ] Update any relevant EmmeMock output
+          milestone: $MILESTONE
+          pinned: false
+          close-previous: false
+

.gitignore

@@ -18,7 +18,7 @@ dist/
 downloads/
 eggs/
 .eggs/
-lib/
+#lib/
 lib64/
 parts/
 sdist/
@@ -63,6 +63,7 @@ scratch/*
 *.bak
 .cache
 .hubstorinfo
+examples/temp_acceptance/*
 
 # Unit test / coverage reports
 htmlcov/
@@ -85,6 +86,9 @@ coverage.xml
 # mkdocs documentation
 site/*
 
+# mkdocs documentation
+site/*
+
 # Jupyter
 .ipynb_checkpoints
 profile_default/
@@ -128,4 +132,17 @@ dmypy.json
 
 # Pyre type checker
 .pyre/
-*.log
+
+# Acceptance Criteria temps
+examples/temp_acceptance/boardings_by_line_am.csv
+notebooks/acceptance-transit-network.geojson
+notebooks/boardings_by_segment_am.geojson
+notebooks/tl_2010_06_bg10.*
+notebooks/*.twbx
+
+# Interim data
+data/interim/*
+
+# R Scripts
+scripts/.Rproj.user/*
+scripts/.Rhistory

README.md

@@ -58,6 +58,13 @@ In troubleshooting, sometimes DLL load failure errors would occur which may be r
 
 At load time, the EMME API will always load the geos_c co-located with the EMME API, unless it was already loaded from some other location, which is the case when you import GDAL first. EMME API seems to be compatible with the newer GDAL/geos_c (reminder: not tested!). But this does not appear to be the case the other way around (newer GDAL is not compatible with older geos_c).
 
+Copy and unzip [example_union_test_highway.zip](https://mtcdrive.box.com/s/3entr016e9teq2wt46x1os3fjqylfoge) to a local
+drive and from within that directory run:
+
+```sh
+get_test_data <location>
+tm2py -s scenario.toml -m model.toml
+```
 
 See [starting out](http://bayareametro.github.com/tm2py) section of documentation for more details.
 

bin/get_test_data.bat

@@ -11,7 +11,7 @@ ECHO "Retreiving %TEST_DATA_NAME% data from %TEST_DATA_LOCATION%
 
 SET OUTDIR=%1
 if "%OUTDIR%"=="" SET OUTDIR=DEFAULT_DIRECTORY
-if not exist %OUTDIR% mkdir %OUTDIR%
+if not exist %OUTDIR% mkdir %OUTDIR%  
 CD %OUTDIR%
 ECHO "Writing to %CD%"