Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Acceptance Criteria Infrastructure to Summarize Assignment of On-board Survey #142

Merged
merged 33 commits into from
Apr 22, 2024

Conversation

DavidOry
Copy link
Collaborator

@DavidOry DavidOry commented Mar 4, 2024

What existing problem does the pull request solve and why should we include it?

The existing Acceptance Criteria infrastructure include numerous methods for summarizing observed and simulated data. Here, minor adjustments are made to facilitate the comparison of outcomes from the assignment of the on-board survey data to observed data.

What is the testing plan?

Make sure core Acceptance Criteria summaries are not disturbed by the changes.

Demonstrate the code is solid by discussing how results are verified and covered by tests

  • Code for this PR is covered in tests
  • Code passes all existing tests

Code formatting

Code should be PEP8 compliant before merging by running a package like black

  • Code linted

Applicable Issues

None

@DavidOry DavidOry marked this pull request as ready for review March 4, 2024 21:40
@DavidOry
Copy link
Collaborator Author

@lmz, @gregerhardt, @FlaviaTsang

Per our call today, here are some distance summaries. Note two caveats: (1) we are using the midday roadway distance skim and (2) the skims are composite paths, so the walk trips are those with no probability of taking transit (there are others for which walking is part of the composite path).

  1. For all observed movements (weighted)
count     31,765
trips    357,185
mean         11.14
std          11.41
min           0.187
25%           4.48
50%          10.58
75%          21.15
max          84.93
  1. For movements with a transit path (weighted)
count     27,864
trips    291,011
mean         13.24
std          11.66
min           0.82
25%           6.13
50%          12.56
75%          23.32
max          84.93
  1. For movements with a walk-all-the-way path, but no transit path (weighted)
count     3,901
trips    66,174
mean         1.90
std          0.82
min          0.18
25%          1.41
50%          1.91
75%          2.49
max         10.45

And then the same three summaries for observed trips that start and end in SF.

  1. All observed intra-SF movements (weighted)
count      9,360
trips    152,785
mean          3.98
std           2.25
min           0.18
25%           2.44
50%           3.94
75%           5.96
max          12.88
  1. Intra-SF movements with a transit path (weighted)
count      6,872
trips    106,640
mean          4.95
std           1.99
min           0.82
25%           3.58
50%           4.90
75%           6.64
max          12.88
  1. Intra-SF movements with a walk-all-the-way path, but no transit path (weighted)
count     2,488
trips    46,144
mean         1.73
std          0.63
min          0.18
25%          1.30
50%          1.76
75%          2.24
max          4.20

To me, this strengthens the case to force a transit boarding, as the 25th percentile walk distance is greater than one mile.

@AshishKuls AshishKuls merged commit e68456d into develop Apr 22, 2024
0 of 2 checks passed
@DavidOry DavidOry deleted the add_on_board_assign_summaries branch June 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants