Added UNSAFEFunctionCallToken to represent cloudformation functions t… #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat return strings which are assumed to conform to be the proper string representation of a stricter type, such as a CIDR block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hat return strings which are assumed to conform to be the proper string representation of a stricter type, such as a CIDR block.
The motivation for this change is that using
Fn::GetAttto get the results of a custom resource is essentially aToken[String], which cannot be used with more specific type requirements, such as aToken[CidrBlock]needed for a VPC or Subnet.This change allows for a custom resource to output a value as a string, which can be retrieved with a
Fn::GetAtt, wrapped inUNSAFEFunctionCallToken, and used as a parameter for a another resource. This change is backwards compatable and will not break any existing cftg code.