Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PrivateIpAddress attribute for Instance. #50

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

guoshimin
Copy link
Contributor

Fixes #49.

@tjcorr
Copy link
Collaborator

tjcorr commented Jan 19, 2016

I'm thinking that even though the IP address is a String we should add some type safety to the parameter similar to how CIDRBlock was implemented.

@guoshimin
Copy link
Contributor Author

Yeah, will use CidrBlock instead.

On Tue, Jan 19, 2016 at 8:56 AM, T.J. Corrigan notifications@github.com
wrote:

I'm thinking that even though the IP address is a String we should add
some type safety to the parameter similar to how CIDRBlock
https://github.com/MonsantoCo/cloudformation-template-generator/blob/master/src/main/scala/com/monsanto/arch/cloudformation/model/resource/EC2.scala#L220-L233%5D
was implemented.


Reply to this email directly or view it on GitHub
#50 (comment)
.

@tjcorr
Copy link
Collaborator

tjcorr commented Jan 19, 2016

String -> IPAddress, also adding unit test
@guoshimin
Copy link
Contributor Author

Done. PTAL.

tjcorr pushed a commit that referenced this pull request Jan 19, 2016
Adding PrivateIpAddress attribute for Instance.
@tjcorr tjcorr merged commit 3637442 into Bayer-Group:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants