Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized VPC and security group for RDS #80

Conversation

aniketbhatnagar
Copy link

DBSubnetGroupName and EC2VpcId can now be passed as ParameterRef

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 52.746% when pulling 6be3252 on aniketbhatnagar:Parameterizing-VPC-And-SecurityGroups-For-RDS into 3606e93 on MonsantoCo:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.833% when pulling ef5c76e on aniketbhatnagar:Parameterizing-VPC-And-SecurityGroups-For-RDS into 3606e93 on MonsantoCo:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 53.095% when pulling b39982a on aniketbhatnagar:Parameterizing-VPC-And-SecurityGroups-For-RDS into 3606e93 on MonsantoCo:master.

@tjcorr
Copy link
Collaborator

tjcorr commented Apr 6, 2016

LGTM, merging. Do you need me to cut a release now or should I wait until we get your other issue sorted out?

@tjcorr tjcorr merged commit 25be4bb into Bayer-Group:master Apr 6, 2016
@aniketbhatnagar
Copy link
Author

I think we should wait until the other issue is sorted. No rush. Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants