Issue 95 lambda alias version #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tj-corrigan any objection to accepting this PR? |
| case class `AWS::Lambda::Alias`(name: String, | ||
| AliasName: Token[String], | ||
| FunctionName: Token[ResourceRef[`AWS::Lambda::Function`]], | ||
| FunctionVersion: Token[String], |
There was a problem hiding this comment.
I wonder if this should be a ResourceRef[AWS::Lambda::Version]. If we ever needed to pass it in as a parameter we could make a special type for that as well (see something like #84).
|
I'm going to go ahead and merge this one to clean things up. I'll make the change to |
tjcorr
pushed a commit
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #95 by adding support for Version and Alias resources.