This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtherBilal
commented
Jun 1, 2020
GooglePlacesSearch.propTypes = { | ||
/** reference to Openlayers map object */ | ||
map: PropTypes.object.isRequired, | ||
apiKey: PropTypes.string.isRequired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment on how to get API key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
AtherBilal
commented
Jun 1, 2020
AtherBilal
commented
Jun 1, 2020
const classes = useStyles() | ||
|
||
const DataLoader = (searchString) => { | ||
return fetch(`https://maps.googleapis.com/maps/api/place/findplacefromtext/json?input=${searchString}&inputtype=textquery&fields=geometry&key=${apiKey}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get formatted address for title
stazrad
added
enhancement
New feature or request
team reviewed 👀
PR reviewed by maintainers
labels
Jun 4, 2020
stazrad
approved these changes
Jun 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Safety Checklist:
package.json
&package-lock.json
version numbers to appropriate releasenpm run docs
Quick Description of Changes (+ screenshots for ui changes):
Added a component to search Google places, then center and zoom to the place, lastly it will add a point on the place