-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct Leica image series. #22
Conversation
Hi @One-sixth! Thank you so much for your contribution ❤️ I'll review the PR right away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you implement these two changes that would be great.
We should also add tests with an scn file, but I haven't found a relatively small one yet. Do you have a good resource for a small scn file?
Modified. I tested the Leica-1.scn file and it looks fine. Then I tested Leica-Fluorescence-1.scn and found a new problem about PIL, which may need to open a new issue to discuss this problem. But for this file, openslide can't open it.
|
Nice. Yes this looks like another bug. Let's open a new issue for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this small change and then we'll merge and release a new version. Thank you so much for your contribution!
Modified. |
Thanks again ❤️ |
Fix #21