-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SAS - happy to open PR with some guidance #517
Comments
Hello @StrikerRUS! I have been working on this for the last week and I am close to submit a PR :) (I actually will be interacting from a different GH account and will be submitting a PR from my company's GitHub, need to wait on some legal stuff) The code that has been developed is of such quality! It's all so well thought out, looking forward to submit the PR I have one question though. Most if not all the already supported languages are open source and hence downloadable the github action workers. Your testing pipeline relies on the code being run locally (in the GH Action workers) with whatever language is being tested then parsing the result in python and comparing it to the python output. I was wondering how to go about this with a language like SAS which is not open source and also often not installed as a client tool but rather installed in some remote server? One option I've thought is to expand |
Sounds good!
Yeah, that's a big question!
I don't think that's an option for this project. Such method will require maintenance burden to support that server for which we don't have resources. Maybe there is any basic/community/trial version of SAS we can use? Or we can send request to SAS for very limited personal license that we'll be using here (from the first glance it seems SAS respects open source in some way). |
Added into feature-request hub #490. |
Hello, first of thank you so much for such an amazing package. I have built a thin wrapper around this package that turns the generated VBA code to SAS supporting XGB, Random Forest, CART, logistic and linear regression models. The whole logic is based on regex rules so it's not very robust. Unfortunately, all the code that I have written is part of an enterprise project so I cannot share at this present moment.
A much preferred solution is to use all the built-in logic that you have developed with m2cgen to turn all the supported models into SAS. I'd be happy to open a PR for a
SASInterpreter
and aSASCodeGenerator
but I don't know where to get started from. If you give me some advice/tips I think I'll be able to make this happen!The text was updated successfully, but these errors were encountered: