added Ruby code generator #206
Conversation
|
|
||
| def interpret_bin_num_expr(self, expr, **kwargs): | ||
| if expr.op == ast.BinNumOpType.DIV: | ||
| # Always force float result |
There was a problem hiding this comment.
A brief explanation why would be nice
There was a problem hiding this comment.
There was a problem hiding this comment.
I find using fdiv less polluting code than explicit converting every number to float with .to_f method.
| self.add_block_termination() | ||
|
|
||
| def method_invocation(self, method_name, obj, args): | ||
| return ("(" + str(obj) + ")." + method_name + |
There was a problem hiding this comment.
Why do we need these parentheses (the ones in code not in string)? It makes the code a bit harder to digest
There was a problem hiding this comment.
Btw, while I'm on it, why do we need parentheses around the object?
There was a problem hiding this comment.
It was my initial mistake to not use these parentheses 馃槂 . It was caught by one of our e2e tests. Then I realized that
1.0 + 2.0.fdiv(3) is not the same as (1.0 + 2.0).fdiv(3).
UPD:
We use the same in other interpreters:
m2cgen/m2cgen/interpreters/code_generator.py
Line 160 in c3426aa
Note parentheses around
left and right operands.
Ruby is in top15 TIOBE latest rating: https://www.tiobe.com/tiobe-index/. 馃檪
I expect that adding Ruby support will be demanded not only in pure Ruby itself, but in Ruby on Rails web framework which is among popular frameworks: 1, 2.