Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Coveralls step to the Github Actions workflow #272

Merged
merged 8 commits into from Jul 24, 2020

Conversation

izeigerman
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 22, 2020

Coverage Status

Coverage remained the same at 96.649% when pulling a9cc5b8 on coveralls-github-actions into 02a453e on master.

@izeigerman
Copy link
Member Author

izeigerman commented Jul 22, 2020

Ended up using the coveralls-python directly. See the issue for details.

@izeigerman
Copy link
Member Author

izeigerman commented Jul 22, 2020

The runtime for r_lang is rather ridiculous. @StrikerRUS I'm leaning towards following your advice and keep it on Travis for now. Although I don't like the idea of using 2 services for the exact same purpose but it appears to be a lesser evil than a ~180 minute long runtime. What do you think?

Otherwise Coveralls seems to be working with Github Actions 🎉

@StrikerRUS
Copy link
Member

I think we can drop Travis CI for now. I have one idea how to fix long R runtime tests. If it doesn't work, we can add Travis config with only R job back. I believe that with current frequency of PRs long CI jobs are not something crucial for us.

Copy link
Member

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for setting up Coveralls for GitHub Actions! Just two minor comments below.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@izeigerman
Copy link
Member Author

@StrikerRUS thanks for the review! I've addressed your comments and dropped the Travis config.

@izeigerman
Copy link
Member Author

@StrikerRUS I've just realized that it's super annoying to maintain the list of required checks using their names since we can reshuffle language E2E tests. Plus github stores the history of all builds:
Screen Shot 2020-07-23 at 9 24 25 AM
The list of checks will keep growing and picking the right check will become rather error prone. I wonder whether we should consider removing the LANG variable from the job name. It will look less nice but at least it should be easier to maintain.

Copy link
Member

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's super annoying to maintain the list of required checks

Yeah! It is absolutely true. We have already faced this problem in LightGBM repo.

I wonder whether we should consider removing the LANG variable from the job name.

Sounds reasonable! Please feel free to choose any job name that will help to maintain checks list with less pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants