New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Coveralls step to the Github Actions workflow #272
Conversation
eaf7229
to
cc2fa8c
Compare
Ended up using the coveralls-python directly. See the issue for details. |
The runtime for Otherwise Coveralls seems to be working with Github Actions 🎉 |
I think we can drop Travis CI for now. I have one idea how to fix long R runtime tests. If it doesn't work, we can add Travis config with only R job back. I believe that with current frequency of PRs long CI jobs are not something crucial for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for setting up Coveralls for GitHub Actions! Just two minor comments below.
c982462
to
35e8998
Compare
@StrikerRUS thanks for the review! I've addressed your comments and dropped the Travis config. |
@StrikerRUS I've just realized that it's super annoying to maintain the list of required checks using their names since we can reshuffle language E2E tests. Plus github stores the history of all builds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's super annoying to maintain the list of required checks
Yeah! It is absolutely true. We have already faced this problem in LightGBM repo.
I wonder whether we should consider removing the LANG variable from the job name.
Sounds reasonable! Please feel free to choose any job name that will help to maintain checks list with less pain.
No description provided.